Skip to content

Update WorkbenchActionBuilder to use IEclipsePreferences#4061

Merged
HeikoKlare merged 1 commit into
eclipse-platform:masterfrom
deepika-u:use_ieclipsepreferences_instead
Jun 8, 2026
Merged

Update WorkbenchActionBuilder to use IEclipsePreferences#4061
HeikoKlare merged 1 commit into
eclipse-platform:masterfrom
deepika-u:use_ieclipsepreferences_instead

Conversation

@deepika-u
Copy link
Copy Markdown
Contributor

@deepika-u deepika-u commented Jun 4, 2026

IEclipsePreferences is used to modernize WorkbenchActionBuilder by updating references of org.eclipse.core.runtime.Preferences.

Partially fixes
eclipse-platform/eclipse.platform#497

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026 •
edited
Loading

Test Results

   861 files  ±0     861 suites  ±0   58m 13s ⏱️ + 3m 13s
 8 034 tests ±0   7 791 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 541 runs  ±0  19 886 ✅ ±0  655 💤 ±0  0 ❌ ±0 

Results for commit 7174bcc. ± Comparison against base commit 04da440.

♻️ This comment has been updated with latest results.

@deepika-u deepika-u force-pushed the use_ieclipsepreferences_instead branch from e287fab to d1adb7a Compare June 5, 2026 05:02
@deepika-u
Copy link
Copy Markdown
Contributor Author

deepika-u commented Jun 5, 2026

@HeikoKlare
When you get some time, can you take a look at this please?

HeikoKlare
HeikoKlare reviewed Jun 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this enhancement. The change looks reasonable to me.
Just as a minor comment: the change regarding usage of CommandContributionItemParameter seems unrelated to preferences. It would be cleaner to have that in a separate commit/PR to stay at one concern per commit (or otherwise at least explain that change in the commit message and PR as well).

@deepika-u
Copy link
Copy Markdown
Contributor Author

deepika-u commented Jun 8, 2026

Thank you for this enhancement. The change looks reasonable to me. Just as a minor comment: the change regarding usage of CommandContributionItemParameter seems unrelated to preferences. It would be cleaner to have that in a separate commit/PR to stay at one concern per commit (or otherwise at least explain that change in the commit message and PR as well).

Sure will separate it away. Actually that change was handling an illegal reference warning.

@deepika-u deepika-u mentioned this pull request Jun 8, 2026
Merged
@deepika-u deepika-u force-pushed the use_ieclipsepreferences_instead branch 6 times, most recently from a4e4ae4 to 0fffb15 Compare June 8, 2026 07:36
@deepika-u
Copy link
Copy Markdown
Contributor Author

deepika-u commented Jun 8, 2026 •
edited
Loading

@HeikoKlare
Created new pr -> #4068 for the other change.

Thanks for your time :)

@deepika-u deepika-u force-pushed the use_ieclipsepreferences_instead branch from 0fffb15 to 7174bcc Compare June 8, 2026 08:52
@HeikoKlare
Copy link
Copy Markdown
Contributor

HeikoKlare commented Jun 8, 2026

Thank you for the update. The change looks fine now.

@HeikoKlare HeikoKlare merged commit ea2f35b into eclipse-platform:master Jun 8, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HeikoKlare HeikoKlare HeikoKlare left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deepika-u @HeikoKlare